Add Sql Server tests and improve logging#8086
Merged
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new functional tests for SQL Server integration and improves the logging mechanism during database creation.
- Adds tests for resilient database creation and multiple database scenarios.
- Updates logging to use ResourceLoggerService to provide better contextual logging.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.SqlServer.Tests/SqlServerFunctionalTests.cs | Adds functional tests covering resilient and multi-database creation scenarios. |
| src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs | Updates logging to use ResourceLoggerService for enhanced resource context logging. |
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs:262
- Ensure that 'sqlDatabase.Parent' reliably returns a valid resource context for logging; if there is any chance it could be null, it may lead to a runtime exception.
var logger = serviceProvider.GetRequiredService<ResourceLoggerService>().GetLogger(sqlDatabase.Parent);
danmoseley
approved these changes
Mar 15, 2025
RussKie
added
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added more tests for AddDatabase (taken from the Postgres work).
Changed database creation logging failure to use the resource logging.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):